Expand tests and Add ignore_paths functionality. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally you can just specify a file within a managed directory as a separate file resource to adjust its permissions separately, but this doesn't work with recursive_file_permissions. This adds functionality to specifically ignore paths to allow them to be managed separately.
* Ignore line length in `spec/defines/init_spec.rb` as we have a lot of long string literals * Remove extra whitespace
Author
|
Hi @npwalker, Have you had a chance to look at this? |
Owner
|
@markeganfuller sorry I didn't see this. I don't think I'll be able to look at this. Let me see if I can find someone to take a look at this. |
|
Any chance this can make it into the module it's functionality I'd really like to have. |
Owner
|
@parryb I'm not actively maintaining this module anymore. You can feel free to fork it and repost it to the forge or just fork it internally for your own use. |
Author
|
@npwalker Would you be interested in migrating this to vox pupuli? |
|
I will fork and like to pull in your pull request, and post to forge. I think it would be a great addition to Vox. But in the meantime I will fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally you can just specify a file within a managed directory as a
separate file resource to adjust its permissions separately, but this
doesn't work with recursive_file_permissions. This adds functionality to
specifically ignore paths to allow them to be managed separately.
This also greatly expands the tests (mainly to be sure I didn't break anything with the new functionality)