Skip to content

Conversation

jotare
Copy link
Contributor

@jotare jotare commented May 2, 2025

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team May 2, 2025 15:30
@jotare jotare changed the base branch from main to generic-rank-fusion May 2, 2025 15:33
Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 92.48555% with 26 lines in your changes missing coverage. Please review.

Project coverage is 84.53%. Comparing base (091960e) to head (52f5e64).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nucliadb/src/nucliadb/search/search/plan/models.py 80.95% 8 Missing ⚠️
nucliadb/src/nucliadb/search/search/plan/query.py 87.50% 6 Missing ⚠️
nucliadb/src/nucliadb/search/search/plan/utils.py 91.93% 5 Missing ⚠️
nucliadb/src/nucliadb/search/search/find.py 94.20% 4 Missing ⚠️
...liadb/src/nucliadb/search/search/plan/serialize.py 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3100      +/-   ##
==========================================
+ Coverage   84.46%   84.53%   +0.06%     
==========================================
  Files         510      518       +8     
  Lines       37829    38259     +430     
  Branches    11562    11562              
==========================================
+ Hits        31954    32341     +387     
- Misses       5327     5368      +41     
- Partials      548      550       +2     
Flag Coverage Δ
nidx 77.86% <ø> (-0.02%) ⬇️
nucliadb-ingest 42.50% <47.10%> (+0.47%) ⬆️
nucliadb-reader 42.30% <47.10%> (+0.05%) ⬆️
nucliadb-search 46.40% <92.48%> (+0.76%) ⬆️
nucliadb-standalone 46.25% <47.10%> (-0.03%) ⬇️
nucliadb-train 44.82% <47.10%> (+<0.01%) ⬆️
nucliadb-writer 46.60% <47.10%> (-0.03%) ⬇️
nucliadb_dataset 56.47% <ø> (ø)
nucliadb_models 83.79% <ø> (ø)
nucliadb_telemetry 85.10% <ø> (ø)
nucliadb_utils 84.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotare jotare marked this pull request as draft May 5, 2025 10:45
Base automatically changed from generic-rank-fusion to main May 5, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant