Skip to content

Conversation

@lferran
Copy link
Contributor

@lferran lferran commented Oct 28, 2025

Description

[sc-13251]

How was this PR tested?

  • todo

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.96%. Comparing base (efaba96) to head (bcf3c24).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
nucliadb/src/nucliadb/search/search/chat/prompt.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3352      +/-   ##
==========================================
- Coverage   85.99%   85.96%   -0.04%     
==========================================
  Files         530      530              
  Lines       43476    43488      +12     
  Branches    12104    12104              
==========================================
- Hits        37389    37386       -3     
- Misses       5503     5513      +10     
- Partials      584      589       +5     
Flag Coverage Δ
nidx 79.51% <ø> (-0.12%) ⬇️
nucliadb 74.95% <95.83%> (+<0.01%) ⬆️
nucliadb-ingest 45.17% <25.00%> (-0.01%) ⬇️
nucliadb-reader 44.88% <25.00%> (-0.01%) ⬇️
nucliadb-search 49.18% <25.00%> (-0.01%) ⬇️
nucliadb-standalone 48.02% <25.00%> (-0.01%) ⬇️
nucliadb-train 45.66% <25.00%> (-0.01%) ⬇️
nucliadb-writer 48.75% <25.00%> (-0.01%) ⬇️
nucliadb_dataset 75.81% <60.00%> (ø)
nucliadb_models 79.73% <100.00%> (ø)
nucliadb_sdk 85.30% <100.00%> (ø)
nucliadb_telemetry 82.91% <ø> (ø)
nucliadb_utils 81.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lferran lferran requested a review from jotare October 31, 2025 09:08
Copy link
Contributor

@jotare jotare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to add this to Hydrate API too

@lferran lferran merged commit 85212e2 into main Oct 31, 2025
41 checks passed
@lferran lferran deleted the field-extension-by-prefic branch October 31, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants