Skip to content

Conversation

@vigith
Copy link
Member

@vigith vigith commented Nov 8, 2025

Closes #268

Tested in CWS

INFO:__main__:User Defined Sink: {"id":"1762630320511035393-0","value":1762630320511035310}
INFO:__main__:User Defined Sink: {"id":"1762630320511036643-0","value":1762630320511036560}
INFO:__main__:User Defined Sink: {"id":"1762630320511038435-0","value":1762630320511038351}
INFO:__main__:User Defined Sink: {"id":"1762630320511039601-0","value":1762630320511039518}
INFO:__main__:User Defined Sink: {"id":"1762630320511041601-0","value":1762630320511041518}
INFO:__main__:User Defined Sink: {"id":"1762630320511043143-0","value":1762630320511043060}
INFO:__main__:User Defined Sink: {"id":"1762630320511044268-0","value":1762630320511044185}
INFO:__main__:User Defined Sink: {"id":"1762630320511046143-0","value":1762630320511046060}

Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.85%. Comparing base (83eeb23) to head (d09310e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   93.63%   93.85%   +0.21%     
==========================================
  Files          65       66       +1     
  Lines        2907     3009     +102     
  Branches      152      155       +3     
==========================================
+ Hits         2722     2824     +102     
  Misses        135      135              
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
@vigith vigith marked this pull request as ready for review November 9, 2025 16:29
@vigith vigith requested review from ab93 and whynowy as code owners November 9, 2025 16:29
@vigith vigith requested a review from BulkBeing November 9, 2025 16:35
// if not finished, abort it
if !sig_handle.is_finished() {
println!("Aborting signal handler");
let _ = sig_handle.abort();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method doesn't return anything. The let binding can be removed.

return responses


async def start(f: callable):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type annotation looks wrong. Shouldn't it be collections.abc.Callable ?

Signed-off-by: Vigith Maurice <[email protected]>
@vigith vigith merged commit d9c9192 into main Nov 10, 2025
11 checks passed
@vigith vigith deleted the sink branch November 10, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sink - pynumaflow-lite

3 participants