Add Custom Modules to Timetable #3373
Open
seanlowjk wants to merge 100 commits intonusmodifications:masterfrom
Open
Add Custom Modules to Timetable #3373seanlowjk wants to merge 100 commits intonusmodifications:masterfrom
seanlowjk wants to merge 100 commits intonusmodifications:masterfrom
Conversation
Member
|
Updated:
Future PRs and Issues to Add:
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Resolves #2040
The idea is to implement custom modules for students who wish
to add modules that are not part of the NUS curriculum (DYOMs)
or TA classes. (Especially for SoC TAs)
Implementation
Timetable.-.NUSMods.-.Google.Chrome.2021-12-15.17-38-22.mp4
With guidance from @chrisgzf , we have developed a solution which allows
users to add their custom modules.
This is done via
CustomLessons which are notreadonly. As a result, we canincorporate these custom lessons into the
TimetablesStateto be stored for future use.Other Information
regards to the export feature?
if there is room for improvement.
TODOs