Improve default font, mouse, and line thickness scaling on macOS#228
Improve default font, mouse, and line thickness scaling on macOS#228JingRyu wants to merge 0 commit intonutti:masterfrom
Conversation
There was a problem hiding this comment.
Thank you for raising PR!
I think this scaling difference comes from the dpi.
We can use below Python API to change DPI automatically.
https://docs.blender.org/api/current/bpy.types.PreferencesSystem.html#bpy.types.PreferencesSystem.dpi
https://docs.blender.org/api/current/bpy.types.PreferencesSystem.html#bpy.types.PreferencesSystem.pixel_size
What do you think?
src/screencast_keys/preferences.py
Outdated
| default=int(bpy.context.preferences.ui_styles[0].widget.points), | ||
| default=int( | ||
| bpy.context.preferences.ui_styles[0].widget.points | ||
| * (5 if is_macos else 1)), |
There was a problem hiding this comment.
I think changing font_size is not good idea because this configuration should be constraint in user side.
Instead, we can change the scale before feeding the font_size to API.
This is same for others.
There was a problem hiding this comment.
Hi nutti, thank you for your suggestion! My quarter is about to end, and I will fix this the next few days!
There was a problem hiding this comment.
@JingRyu
Thank you. It's ok to me.
If you have any help, please let me know.
|
@JingRyu |
2 participants
Purpose of the pull request
Improve default display scaling on macOS
Description about the pull request
Adjust default
font_size,mouse_size, andline_thicknessfor better visibility on macOS Retina displays.Additional comments [Optional]
I’m happy to contribute for macOS users. Thank you for maintaining this project!