Skip to content

fix: terminate the build process when font resolution fails #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: terminate the build process when font resolution fails #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,7 @@ export default defineNuxtModule<ModuleOptions>({
// Rewrite font source URLs to be proxied/local URLs
const fonts = normalizeFontData(result?.fonts || [])
if (!fonts.length || !result) {
logger.warn(`Could not produce font face declaration from \`${override.provider}\` for font family \`${fontFamily}\`.`)
return
throw new Error(`Could not produce font face declaration from \`${override.provider}\` for font family \`${fontFamily}\`.`)
}
const fontsWithLocalFallbacks = addFallbacks(fontFamily, fonts)
exposeFont({
Expand Down Expand Up @@ -251,7 +250,7 @@ export default defineNuxtModule<ModuleOptions>({
}
}
if (override) {
logger.warn(`Could not produce font face declaration for \`${fontFamily}\` with override.`)
throw new Error(`Could not produce font face declaration for \`${fontFamily}\` with override.`)
}
}
}
Expand Down