Skip to content

core.tangle: Move fd close into callback #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brownjohnf wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

core.tangle: Move fd close into callback #1763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lua/neorg/modules/core/tangle/module.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,12 @@ module.on_event = function(event)
end

vim.uv.fs_write(fd, write_content, 0, function(werr)
-- Whether or not we successfully wrote the file, close the fd.
vim.uv.fs_close(fd, function(err)
assert(not err, lib.lazy_string_concat("Failed to close file '", file, "' for tangling: ", err))
end)

-- Now that we've cleaned up the fd, we can notify of any failures.
assert(not werr, lib.lazy_string_concat("Failed to write to '", file, "' for tangling: ", werr))
tangled_count = tangled_count + 1
file_count = file_count - 1
Expand All @@ -533,9 +539,6 @@ module.on_event = function(event)
)
end
end)
vim.uv.fs_close(fd, function(err)
assert(not err, lib.lazy_string_concat("Failed to close file '", file, "' for tangling: ", err))
end)
end)
::continue::
end
Expand Down