fix: properly handle ranges ending with a newline #828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #827 . The changes are similar to the ones in #812 , but they are different from the function mentioned in a comment of that PR (#812 (comment)) because said function assumes that the range returned is end-inclusive, while this plugin currently is treating the range as end_exclusive.
This bug was surfaced by #687 (because and
end_row, end_colpair like4, 0becomes4, -1after the change), but this wasn't working properly before #687 either. The behavior before that PR was to also select the first character of the next line (so, one character after the newline).