Create assert_field_offsets! macro
#22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, it cannot be implemented soundly. It needs both rust-lang/rust#63810 and rust-lang/rust#64588, as well as allowing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
assert_field_offsets!for ensuring that givenstructfields are at specific offsets.This current implementation works in Rust 1.37 and 1.38. However, the current beta and nightly compilers fail to perform the constant evaluation. This is not unexpected since the current code creates a reference at
mem::align_of::<T>(), where there is no initialized memory. Even though the reference is non-null, dereferencing those addresses is definitely undefined behavior.I won't be merging this PR as-is. However, I'm interested to learn how this macro could be implemented in a sound way.
See also: Gilnaa/memoffset#24.
(cc @oli-obk @RalfJung)