Skip to content

Update outdated links#150

Merged
tschmidtb51 merged 7 commits intooasis-open:mainfrom
csaf-auxiliary:update-links
Dec 3, 2025
Merged

Update outdated links#150
tschmidtb51 merged 7 commits intooasis-open:mainfrom
csaf-auxiliary:update-links

Conversation

@vkrasnovyd
Copy link
Contributor

@vkrasnovyd vkrasnovyd commented Nov 24, 2025

vkrasnovyd and others added 5 commits November 24, 2025 16:52
  * change link to external BSD license to an internal one, as this
    is obviously the intention of the previous link.
  * Change link to LICENCE to LICENCE.md which has the licensing
    overview for this directory. This is an improvement as the
    repository always contained files with different copyright holders
    (and different compatible licenses).
@bernhardreiter
Copy link
Contributor

Inspected the changes and made a few small improvements.

Dear maintainers (@sthagen, @justmurphy, @tschmidtb51), please merge. This improvement makes sure that potential future contributors will see the current information on how to contribute (see #148 for the problem it solves).

@tschmidtb51 tschmidtb51 self-assigned this Nov 28, 2025
@tschmidtb51 tschmidtb51 self-requested a review November 28, 2025 19:31
Copy link
Collaborator

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks like the transformations from HMTL to Markdown with a small bunch of fixes as we changed the default branch...

I found one issue in the CVRF README.

@OASIS-OP-Admin: Can we do that change as suggested?

@sthagen
Copy link
Contributor

sthagen commented Nov 28, 2025

As @tschmidtb51 stated, we need to know, if someone else than OASIS should change and I myself am not sure what the goal of the changes is (aside from the license URL fix). Thanks.

Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cf. my comment from a minute ago or so. Thanks.

@bernhardreiter
Copy link
Contributor

bernhardreiter commented Dec 1, 2025

we need to know, if someone else than OASIS should change

The changes as we have intended them were meant to keep the contents itself.
Only the representation within this repository should have been improved the fixed contents where it was broken. (So from my point of view official clearance is not necessary, unless the representation needs to be cleared as well. )

I myself am not sure what the goal of the changes is (aside from the license URL fix).

#148 described the main problem: broken internal links towards the wrong branch.

Additional fixes and improvements:

  • simply representation of links from HTML (which is allowed in Markdown) to a relative Markdown link. It is easier to read and point to the current branch which is good for developing changes in other git branches.
  • Fix for bad contents in
  • (fix license link to a working)

Copy link
Contributor

@claurau claurau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tschmidtb51 tschmidtb51 merged commit a57ee34 into oasis-open:main Dec 3, 2025
3 checks passed
@vkrasnovyd vkrasnovyd deleted the update-links branch December 3, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

internal https links go to outdated branch master

7 participants