Merged
Conversation
chisholm
suggested changes
Apr 10, 2025
Contributor
|
observed-string unit tests pass again. So it seems good to go now. I can't run tests for incident because it seems the implementation was changed without updating unit tests, so the unit tests no longer work. Also, the "applies_to" arg on @CustomExtension is not in a Pypi released version of the stix2 library, so that code won't work with a stock set of dependencies anyway. Aside from that, the extension implementations look good now. |
Contributor
Author
|
Yes - we need to decide if we want to release a new version of python-stix. It has been 4 years. I'm not sure how comfortable I feel about including the relational-db datastore. I think the neo4j one should stay in its own branch |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#26 and #27