Skip to content

Add form building hooks and components #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
csillag wants to merge 71 commits into
base: master
Choose a base branch
from
Draft

Add form building hooks and components #40

csillag wants to merge 71 commits into from

Conversation

@csillag
Copy link
Collaborator

@csillag csillag commented Jun 17, 2025 •
edited
Loading

See the README file and the Storybook pages for details.

Task list

Port hooks and UI components from Blockvote to use widgets and styles from ui-library

  • Generic state management / validation stuff
  • Simple text input
  • Boolean input
  • Date input
  • Select
  • Array List input
  • Code for compiling forms

Integration

  • Get rid of most of CSS code (use the ui-library styles and tailwind)
  • Full linting
  • Add README file describing the general approach
  • Add StoryBook examples for everything
  • Discuss best approach and practices with team. also considering react-hook-form and Shadcn's form stuff, and animation libraries
  • Get rid of all custom CSS code everywhere (fully use the ui-library styles and tailwind)
  • Tune CSS where necessary
  • Fully de-duplicate functionality, considering the chosen libraries and methods

@github-actions
Copy link

github-actions bot commented Jun 17, 2025 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: 3485b8a36bd80bb0517a1fd6e36699f6540d0b8c
Status:✅ Deploy successful!
Preview URL: https://e327ff6a.oasis-ui.pages.dev
Alias: https://pr-40.oasis-ui.pages.dev

@csillag csillag force-pushed the csillag/add-more-logic branch 2 times, most recently from d36df81 to d038c25 Compare June 17, 2025 15:20
@csillag csillag changed the title [W.I.P] Add form building hooks and components Add form building hooks and components Jun 18, 2025
@csillag csillag self-assigned this Jun 18, 2025
csillag added 25 commits July 11, 2025 20:33
@csillag
Add react-markdown dependency
1b8af72
@csillag
Add a helper component for displaying MarkDown
ae4ca3e
@csillag
Add MaybeWithTooltip component
71c3e35
@csillag
Add framer-motion dependency
188e648
@csillag
Add utility class for configurable animations
1c1d719
@csillag
Add a bunch of generic utility functions
ee928fc
@csillag
Add BooleanInput
d8914ac
@csillag
Add spinner animation
fe181fc
@csillag
Add Label and useLabel
10a75c1
@csillag
Add ActionButton and useAction()
c74c715
@csillag
Add TextInput and useTextField()
1445f7e
@csillag
Add SelectInput and useOneOfField()
38c21ef
@csillag
Markdown: add support for applying className
c3deab7
@csillag
useInputField enhancements
67eb729 
- return isEmpty flag as part of controls
- add validateEmptyOnChange flag, to enable
  validation of empty fields on change.
  (Normally empty fields are ignored when
  we are validating because of value change.)
@csillag
useOneOfField: add support for nullable selects
1d4ca28
@csillag
add useDateField() and <DateInput>
ce88598
@csillag
Text input: add support for password mode
85113a0
@csillag
useAction(): improve autogenerated names
68d8ef4
@csillag
All fields: auto-generated labels (except on label)
8625eec
@csillag
Validation: make stillRefresh() optional
2233b61
@csillag
Add StoryBook page for validation
b062a95
@csillag
Boolean input: enable auto-label
245a344
@csillag
Boolean input: enable markdown support for label
c54e7ff
@csillag
Simplify storybook examples
f16aaa2
@csillag
Support shorter form for test and bool fields
e24ce67
csillag and others added 29 commits July 11, 2025 20:33
@csillag
Enable animations by default
11e5f9a
@csillag
Improve form story
9c1fbbe
@csillag
CSS fixes
c62f520
@csillag
Improve field group functions
a0b453a
@csillag
Add some documentation
0507f23
@csillag
Improve docs
b3d1594
@csillag
Improve docs
0203e23
@csillag
doc linting
8a1d603
@csillag
Button: Add optional testId arg
0b6690c
@csillag
Small improvements, mostly for testability
8b3cd7b
@csillag
Clean up storybook for ActionButton
d183888
@csillag
Clean up BooleanInput stories
c634e03
@csillag
Rename MaybeWithTooltip -> WithTooltip
63e0e5b
@csillag
Clean up WithTooltip storybook
c35fcde
@csillag
Avoid displaying empty labels/description
dcca3fb
@csillag
Remove fake storybook tests
ae48e31
@csillag
Simplify some StoryBook test cases
fafa62a
@csillag
Clean up labeloutput storybook stories
8caf6ee
@csillag
Linting fixes
026ce3c
@csillag
Fix failing test cases
f7530ba
@csillag
Fix failing test cases
419fdd1
@csillag
Improve association between input and label
f360c1d 
... currently for text input and boolean input.
(More types coming later as we finalize their storybook
tests.)
@csillag
Add proper test cases for TextInput
9725179
@csillag
Add proper test cases for TextInput
1580ce0
@csillag
Improve SelectInput stories
bc2d6b1
@csillag
Improve SelectInput stories
8920e35
@csillag
Improve select story
f5583e3
@csillag
Improve select story
1c97547
@csillag
Get rid of the ValidatorGenerators concept
3485b8a 
(Accept validators as validator output instead)
@csillag csillag force-pushed the csillag/add-more-logic branch from 788f42d to 3485b8a Compare July 11, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@csillag csillag

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@csillag