Skip to content

Update components exports #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
buberdds wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update components exports #93

buberdds wants to merge 3 commits into from

Conversation

@buberdds
Copy link
Collaborator

@buberdds buberdds commented Nov 24, 2025 •
edited
Loading

Closes #91

  • set custom components as default ones. Avoid issue with importing /components vs auto generated /components/ui/...
  • for now not all components have been aligned with design guide so a few base components are just re-exported to keep imports the same in apps
  • in app we just use one path for imports, base components are still avail via base file (not sure we should expose them though)

Any other preferences/ideas ?

@github-actions
Copy link

github-actions bot commented Nov 24, 2025 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: 29f7b11a775d70ddbe8faddedf9bff06c4b806e4
Status:✅ Deploy successful!
Preview URL: https://ae20ab9d.oasis-ui.pages.dev
Alias: https://pr-93.oasis-ui.pages.dev

@buberdds buberdds force-pushed the mz/export-structure branch from 76c48b4 to 3d290e2 Compare November 24, 2025 16:01
@buberdds buberdds requested review from lubej and lukaw3d December 1, 2025 12:17
@lubej
Copy link
Collaborator

lubej commented Dec 1, 2025

No preferences really, the current implementation looks good to me.

@lukaw3d
Copy link
Member

lukaw3d commented Dec 1, 2025

I have seen export * from discouraged by random tools, but never investigated so I don't know which tools. At least hotreload linter complains about it https://github.com/oasisprotocol/explorer/actions/runs/19824818352

@lukaw3d
Copy link
Member

lukaw3d commented Dec 1, 2025

to avoid importing auto generated files we could have linter rules like
https://github.com/oasisprotocol/explorer/blob/master/.eslintrc.js#L37-L41

@buberdds buberdds marked this pull request as ready for review December 5, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukaw3d lukaw3d Awaiting requested review from lukaw3d

@lubej lubej Awaiting requested review from lubej

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set components export pattern

4 participants

@buberdds @lubej @lukaw3d