Move the management of Jsoo config details out of dune#13613
Open
vouillon wants to merge 1 commit intoocaml:mainfrom
Open
Move the management of Jsoo config details out of dune#13613vouillon wants to merge 1 commit intoocaml:mainfrom
vouillon wants to merge 1 commit intoocaml:mainfrom
Conversation
vouillon
force-pushed
the
jsoo-build-config
branch
from
495d5f7 to
0497c9c
Compare
rgrinberg
pushed a commit
that referenced
this pull request
Feb 18, 2026
Refactor jsoo archive generation to use a demand-driven approach. Previously, rules for all configuration variants were generated upfront whenever a library was built. This logic is now decoupled from general library rules; instead, the build system intercepts requests for specific configuration directories and generates the necessary rules dynamically. This will enable the following improvements: - The config details can be moved out of dune into jsoo (#13613). - This will make it possible to implement a more incremental build process without generating a large volume of unused rules for unrequested configurations (#13612). Signed-off-by: Jérôme Vouillon <jerome.vouillon@gmail.com>
vouillon
force-pushed
the
jsoo-build-config
branch
2 times, most recently
from
ff68af5 to
761f25d
Compare
Dune had to know about all possible Jsoo config to create rules upfront. This is no longer necessary with ocaml#13611. Signed-off-by: Jérôme Vouillon <jerome.vouillon@gmail.com>
vouillon
force-pushed
the
jsoo-build-config
branch
from
761f25d to
7991017
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dune had to know about all possible Jsoo config to create rules upfront. This is no longer necessary with #13611.
The corresponding Js_of_ocaml changes are in ocsigen/js_of_ocaml#2177.