fix(rev_store): only negotiate with relevant tips#13698
Open
Alizter wants to merge 2 commits intoocaml:mainfrom
Open
fix(rev_store): only negotiate with relevant tips#13698Alizter wants to merge 2 commits intoocaml:mainfrom
Alizter wants to merge 2 commits intoocaml:mainfrom
Conversation
rgrinberg
reviewed
Mar 2, 2026
Signed-off-by: Ali Caglayan <alizter@gmail.com>
shym
approved these changes
Mar 2, 2026
Contributor
shym
left a comment
shym
left a comment
There was a problem hiding this comment.
This looks good to me, thank you!
This ensures that the reference subdirectories remain readable. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-ukxyzqyspvrk
branch
from
4e5fce5 to
a50902d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #13671, we restrict how we negotiate from the rev_store to a server to use only the relevant tips.
This is done by name spacing the recorded references by (the hash of) their URL. This way we can provide only the relevant references during negotiation.
This should both speed up negotiation (and hence downloads) and avoid unnecessary communication of rev_store contents.
--negotiation-tipis an argument that was introduced in the minimum supported Git version that we currently have.I've updated the doc/dev/rev_store.md about this new behaviour.