Add missing (require 'ert) for ert-deftest#1823
Closed
andersk wants to merge 1 commit intoocaml:mainfrom
Closed
Conversation
Although the ert-deftest macro is autoloaded, the ert-set-test function used in its expansion is not, leading to ‘Lisp error: (void-function ert-set-test)’. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
|
That would fix the immediate problem, but would slow down loading the package. I think it's better to extract the tests instead as done in #1819. |
Collaborator
|
Thanks for looking into that @andersk ! I will close this PR since the problem should be solved by #1819 Just to understand: because Melpa tracks Merlin main branch the package is currently broken ? If so I will try to merge the patch quickly to fix it. We still need to understand why the test doesn't pass on Emacs <= 28... |
Indeed. |
Collaborator
|
Closing this one in favor of #1827 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the
ert-deftestmacro is autoloaded, theert-set-testfunction used in its expansion is not, leading toLisp error: (void-function ert-set-test)when using byte-compiled configs.