Fix typos and lint across smaller data directories#3495
Conversation
voodoos
left a comment
There was a problem hiding this comment.
Thanks looks good to me. Maybe we should find an other way to put the emphasis you removed in 0op_02_users ? With quote blocks maybe ?
|
|
||
| ## Questions and contact | ||
|
|
||
| If you have any queries or suggestions for the workshop, please contact Didier Remy (<first.last@inria.fr>) or Anil Madhavapeddy (<first.last@cl.cam.ac.uk>). |
There was a problem hiding this comment.
Do markdown parsers detect mail adresses and add mailto: to the link ? If not we should dot it.
There was a problem hiding this comment.
I'm not sure about this, so I'll have to check - most likely we'll have to add the mailto:. For the linter here the problem was links were not marked explicitly as auto-links.
| ## (U1) Application Developer | ||
|
|
||
| _Builds OCaml applications to solve real-world problems_ | ||
| Builds OCaml applications to solve real-world problems. |
There was a problem hiding this comment.
This does have an impact on the resulting formatting right ? Is there a correct way to put emphasis here ?
(same for other sections)
There was a problem hiding this comment.
It does, so I'm on the fence about this one. The linter thinks such cases should be headings (an entire line with emphasis), but I felt it was better to just make it regular text.
Potentially we can disable this rule, but I guess it's not a big deal in general.
…es, and docs Fix heading levels in 96 files: - exercises: `# Solution`/`# Statement` → `## Solution`/`## Statement` (87 files) - conferences: `###` → `##` where `##` was skipped (7 files) - root docs: demote duplicate `#` to `##` (2 files) Extracted from #3493, #3494, #3495 by @bbatsov. This PR isolates the purely mechanical heading-level fixes for easy review. Quick review tip — verify this PR only touches heading lines: git diff -U0 --no-color HEAD~1 | grep '^[+-]' | grep -v '^[+-][+-][+-]' | paste - - | sort | uniq -c | sort -rn Co-Authored-By: Bozhidar Batsov <bozhidar@batsov.dev> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Strip trailing whitespace from 13 exercise files. Extracted from #3493, #3494, #3495 by @bbatsov. This commit isolates the purely mechanical trailing whitespace fixes for easy review. Quick review tip — verify this commit only removes trailing whitespace: git diff -U0 --no-color HEAD~1 | grep '^[+-]' | grep -v '^[+-][+-][+-]' | paste - - | sort | uniq -c | sort -rn Every pair should show identical content differing only by trailing blanks. Co-Authored-By: Bozhidar Batsov <bozhidar@batsov.dev> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Strip trailing whitespace from 13 exercise files. Extracted from #3493, #3494, #3495 by @bbatsov. This commit isolates the purely mechanical trailing whitespace fixes for easy review. Quick review tip — verify this commit only removes trailing whitespace: git diff -U0 --no-color HEAD~1 | grep '^[+-]' | grep -v '^[+-][+-][+-]' | paste - - | sort | uniq -c | sort -rn Every pair should show identical content differing only by trailing blanks. Co-Authored-By: Bozhidar Batsov <bozhidar@batsov.dev> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
) * Fix markdown heading levels (MD025/MD001) across exercises, conferences, and docs Fix heading levels in 96 files: - exercises: `# Solution`/`# Statement` → `## Solution`/`## Statement` (87 files) - conferences: `###` → `##` where `##` was skipped (7 files) - root docs: demote duplicate `#` to `##` (2 files) Safe for exercise rendering: `tool/ood-gen/lib/exercise.ml` splits on `Str.regexp {|#[ ]*Solution|}` which matches `## Solution` equally well since `Str.split` finds the pattern as a substring. Verify this commit only touches heading lines: git diff -U0 --no-color HEAD~1 | grep '^[+-]' | grep -v '^[+-][+-][+-]' | paste - - | sort | uniq -c | sort -rn Co-Authored-By: Bozhidar Batsov <bozhidar@batsov.dev> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove trailing whitespace from exercise files (MD009) Strip trailing whitespace from 13 exercise files. Verify this commit only removes trailing whitespace: git diff -U0 --no-color HEAD~1 | grep '^[+-]' | grep -v '^[+-][+-][+-]' | paste - - | sort | uniq -c | sort -rn Every pair should show identical content differing only by trailing blanks. Co-Authored-By: Bozhidar Batsov <bozhidar@batsov.dev> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add missing final newline to markdown files (MD047) Add missing final newline to 117 markdown files. Verify this commit only adds final newlines: git diff -U0 --no-color HEAD~1 | grep -c '^\\ No newline at end of file' Should output 117 (one per file, all removed). Co-Authored-By: Bozhidar Batsov <bozhidar@batsov.dev> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Bozhidar Batsov <bozhidar@batsov.dev> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
|
Heads up: #3500 was just merged, which includes the MD025/MD001 (heading levels), MD009 (trailing whitespace), and MD047 (missing final newline) fixes extracted from this PR. This branch will need a rebase on |
- Add language specifiers to fenced code blocks (MD040) - Convert bold emphasis used as headings to proper h5 headings (MD036) - Remove emphasis from persona taglines to avoid MD036 false positives
68d2f53 to
ff8411a
Compare
|
Rebased on main (now that #3500 has landed). Conflicts resolved cleanly. Regarding the review feedback:
|
sabine
left a comment
There was a problem hiding this comment.
Thanks, I think overall this is a big improvement.
Summary
siblings_only: trueto MD024 config to allow duplicate subheadings under different parents#####headings in platform roadmap (MD036)Test plan
npx markdownlint-cli2reports 0 errors across all targeted directories