[Design] Proposal for pylibseekdb Build Information#131
Open
zamaoxiaoji wants to merge 1 commit intooceanbase:developfrom
Open
[Design] Proposal for pylibseekdb Build Information#131zamaoxiaoji wants to merge 1 commit intooceanbase:developfrom
zamaoxiaoji wants to merge 1 commit intooceanbase:developfrom
Conversation
Member
|
This solution will fix #110. |
3 tasks
Member
|
This solution looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Description
Currently,
pylibseekdbusers have no way to determine the exact build information of the library they are using, such as:Solution Description
Currently,
pylibseekdbusers have no way to determine the exact build information of the library they are using, such as:Passed Regressions
Verify output matches expected format after build:
python3 -c "import libseekdb_python as seekdb; seekdb.print_version()"Expected output format:
Upgrade Compatibility
__version__: Currently exists but returns data version (e.g., "1.1.0.0"). We will keep this behavior or enhance it to returnPACKAGE_VERSIONwhich is more meaningful for users.build_info,print_version(),get_version_string()are purely additive and do not break existing code.