This repository was archived by the owner on Aug 22, 2023. It is now read-only.
fix: add missing flag property - multiple#113
Open
MunifTanjim wants to merge 1 commit intooclif:mainfrom
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 2 2
Lines 12 12
Branches 3 3
======================================
Misses 12 12 Continue to review full report at Codecov.
|
Author
|
@RasPhilCo any chance of getting this merged? Or any suggestion? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for correctly suggesting flags mutiple times (only if the flag supports it) in shell completion.
Without merging this PR, this feature can't be implemented on the shell completion plugin I'm working on:
https://github.com/MunifTanjim/oclif-plugin-completion/blob/62329f6b65b8523e0a1d0994c690c3b709c8791b/src/utils/bash.ts#L335-L340