This repository was archived by the owner on Aug 22, 2023. It is now read-only.
Open
Conversation
This commit makes `commandIDs` return space-separated commands instead of colon-separated.
This was referenced Nov 14, 2018
Contributor
|
@oclif @heroku-cli I'm happy to champion this PR if you're willing to review it :) |
|
Any thoughts on this PR from @heroku-cli team? We'd very much like to use something like this, even if it means updating/forking some of the plugins (like the help plugin) to achieve the space-separated subcommand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b9775af shows how to possibly make
commandIDsreturn space-separated commands (user add) instead of colon-separated (user:add).I opened this PR to gather feedback how to best do it. Can it be achieved without modifying
plugin.ts? Should it be configurable viapackage.jsonlike this?{ "oclif": { "commandSeparator": " " } }Related: