Skip to content

Conversation

@frva-odoo
Copy link
Contributor

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented Oct 9, 2025

Pull request status dashboard

@frva-odoo frva-odoo force-pushed the 19.0-accounting-firm-id-aml-frva branch 2 times, most recently from c59dee0 to 67b2b6e Compare October 10, 2025 14:29
@frva-odoo frva-odoo force-pushed the 19.0-accounting-firm-id-aml-frva branch from 67b2b6e to 0d5f42e Compare October 10, 2025 14:54
@frva-odoo frva-odoo force-pushed the 19.0-accounting-firm-id-aml-frva branch from 242ac8e to 49ba33b Compare October 28, 2025 11:35
Copy link
Collaborator

@vava-odoo vava-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!
You'll need to rebase (error with cloc will disappear) and solve the conflict.
There is still an issue with runbot with a date field.

<field name="model_id" ref="base.model_res_partner"/>
<field name="state">code</field>
<field name="code"><![CDATA[
for contact in model.search([('x_id_expiration_date', '!=', False), ('x_id_expiration_date', '<=', datetime.datetime.today().date() + dateutil.relativedelta.relativedelta(days=7))]):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a detailed but you changed this in your last push. Was it intended?

Suggested change
for contact in model.search([('x_id_expiration_date', '!=', False), ('x_id_expiration_date', '<=', datetime.datetime.today().date() + dateutil.relativedelta.relativedelta(days=7))]):
for contact in model.search([('x_id_expiration_date', '!=', False), ('x_id_expiration_date', '<', datetime.datetime.today().date() + dateutil.relativedelta.relativedelta(days=7))]):

Comment on lines +79 to +80
for partner in records:
partner.message_post(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there another type of server action for generic actions like sending an email?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants