Skip to content

Restructure the PolynomialCompressor classes#826

Open
fwitte wants to merge 2 commits intodevfrom
fix/#825-restructure-poly-compressors
Open

Restructure the PolynomialCompressor classes#826
fwitte wants to merge 2 commits intodevfrom
fix/#825-restructure-poly-compressors

Conversation

@fwitte
Copy link
Copy Markdown
Member

@fwitte fwitte commented Nov 6, 2025

Resolve #825

The PolynomialCompressor classes have some special touch to them, as

  • they require a precalculation step and
  • you pass some parameters through a dictionary to the component (the reference_state)

This leads to the fact, that the reference_state specific parameters come in a specific unit, which cannot be deviated from. Breaking up the reference state into its single elements and using those will be an extra step, as the reference_state dictionary is also passed to the precalculation method. It should be discussed with the of the (power) users of this component, what is the most reasonable API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename rpm of PolynomialCompressor to frequency

1 participant