Open
Conversation
add parameter for NO creation ratio
adjust oxygen residuals for nitrogen shortage case fix wrong sign in nitrogen residuals rearrange code
fix wrong nitrogen residual
Member
|
Hi @HaSchneider, thank you very much for bringing this up, very cool addition! I will review it in the next weeks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements optional NO creation in combustion component. When the f_nox parameter is set, NO is created in the combustion, as long as enough oxygen and nitrogen is available. f_nox is the ratio of mass flow of created NO in relation to the fuel mass flow.
But there are still some issues...
Issues:
coolprop does not have NO fluid implemented
combustion component does not allow other fluid property engines than coolprop. I solved that as described in Not possible to use other fluid property engines than coolprop in combustion component #887.
Pyromat wrapper can be used instead, but:
I solved that in the example by creating my own pyromat wrapper with the needed values and by adding a dummy NO flow in the inputs with the corresponding pyromat wrapper as fluid property engine. I think it would be better if this can be done automaticaly in the combustion component, but I have no idea how.
following components might fail, due to missing fluid properties in the pyromat wrapper engine. This is demonstrated in the test_CombustionChamber_NO. I think this cant be solved proper as long as pyromat does not contain all needed properties and coolprop does not contain NO. So missing properties must be added manualy to the pyromat wrapper.
Example
{'CO2': 0.03923764451245059, 'Ar': 0.012711828022584415, 'H2': 0.0, 'N2': 0.7442833087203439, 'NO': 1.8229232332386296e-06, 'O2': 0.17101940248021757, 'H2O': 0.03274599334117038, 'CH4': 0.0}