Skip to content

ops: improve pipeline speed?#6

Closed
ojsef39 wants to merge 10 commits intomainfrom
test
Closed

ops: improve pipeline speed?#6
ojsef39 wants to merge 10 commits intomainfrom
test

Conversation

@ojsef39
Copy link
Copy Markdown
Owner

@ojsef39 ojsef39 commented Feb 18, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 18, 2026 10:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the CI/CD pipeline by migrating from Nix-based installation to Python pip-based installation of flake-review. This change aims to improve pipeline execution speed by avoiding the overhead of building or downloading the Nix package. The workflow now supports two installation modes: installing from a git reference (default for external repos) or from the checked-out repository (for testing flake-review PRs).

Changes:

  • Replaced flake-ref input parameter with flake-review-ref and install-from-checkout for more flexible installation options
  • Changed from nix run to direct flake-review command execution after pip installation
  • Removed Nix installation from the post-results job (only needed for the review job)
  • Updated comments to reflect the new installation approach

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/flake-review.yml Updated to use new install-from-checkout parameter instead of flake-ref for testing PRs to flake-review itself
.github/workflows/flake-review-reusable.yml Replaced Nix-based installation with pip-based installation, added new input parameters, and simplified post-results job by removing unnecessary Nix setup

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/flake-review-reusable.yml
@ojsef39 ojsef39 force-pushed the test branch 4 times, most recently from f99d6e4 to 431790c Compare February 18, 2026 15:57
@ojsef39 ojsef39 force-pushed the test branch 6 times, most recently from b66c854 to 95be73c Compare February 18, 2026 16:58
@ojsef39 ojsef39 force-pushed the test branch 2 times, most recently from 8eb9cec to 951a80e Compare February 18, 2026 18:08
@github-actions
Copy link
Copy Markdown

Flake Review Results for #6

Available systems: aarch64-darwin, aarch64-linux, x86_64-darwin, x86_64-linux
Requested systems: aarch64-darwin, aarch64-linux, x86_64-darwin, x86_64-linux

🔄 Modified (8)

  • packages.aarch64-darwin.default

    • Output: /nix/store/y1iim8dgzzb38pg3rndv9kmj4kbr7z7v-flake-review-0.1.0
    Derivation diff
    - /nix/store/jxjn1wic0gairx8dih7va50ha1hs01m8-flake-review-0.1.0.drv:{out}
    + /nix/store/vb5v3s21nlwsmin62khq6rmqcxgvpf3y-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        ←/nix/store/4mw2l24mfii0jza5hxjjb3fad14s6a6m-source←→/nix/store/09myv4bvvj05cz9z6rg134mqdandb9l4-source→
    ''
  • packages.aarch64-darwin.flake-review

    • Output: /nix/store/y1iim8dgzzb38pg3rndv9kmj4kbr7z7v-flake-review-0.1.0
    Derivation diff
    - /nix/store/jxjn1wic0gairx8dih7va50ha1hs01m8-flake-review-0.1.0.drv:{out}
    + /nix/store/vb5v3s21nlwsmin62khq6rmqcxgvpf3y-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        ←/nix/store/4mw2l24mfii0jza5hxjjb3fad14s6a6m-source←→/nix/store/09myv4bvvj05cz9z6rg134mqdandb9l4-source→
    ''
  • packages.x86_64-darwin.default

    • Output: /nix/store/6ww3fscln7jlmgkjnmzskizwkhm7c8g5-flake-review-0.1.0
    Derivation diff
    - /nix/store/3ybp1xkffp2g4m23rxj333l2y8bfqcs9-flake-review-0.1.0.drv:{out}
    + /nix/store/ahqqwzf5kcb6wpcnf60dj1vbj8xmhx9g-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        ←/nix/store/4mw2l24mfii0jza5hxjjb3fad14s6a6m-source←→/nix/store/09myv4bvvj05cz9z6rg134mqdandb9l4-source→
    ''
  • packages.x86_64-darwin.flake-review

    • Output: /nix/store/6ww3fscln7jlmgkjnmzskizwkhm7c8g5-flake-review-0.1.0
    Derivation diff
    - /nix/store/3ybp1xkffp2g4m23rxj333l2y8bfqcs9-flake-review-0.1.0.drv:{out}
    + /nix/store/ahqqwzf5kcb6wpcnf60dj1vbj8xmhx9g-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        ←/nix/store/4mw2l24mfii0jza5hxjjb3fad14s6a6m-source←→/nix/store/09myv4bvvj05cz9z6rg134mqdandb9l4-source→
    ''
  • packages.aarch64-linux.default

    • Output: /nix/store/hykdnmx20f47c9ryhxy2dkssrq83kbmn-flake-review-0.1.0
    Derivation diff
    - /nix/store/nbnqr442x2r8vhwxbafdswqsmxf7sr8d-flake-review-0.1.0.drv:{out}
    + /nix/store/3gjrgciwqqx7hvmm4hsz0qh7hjab76b2-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        ←/nix/store/4mw2l24mfii0jza5hxjjb3fad14s6a6m-source←→/nix/store/09myv4bvvj05cz9z6rg134mqdandb9l4-source→
    ''
  • packages.aarch64-linux.flake-review

    • Output: /nix/store/hykdnmx20f47c9ryhxy2dkssrq83kbmn-flake-review-0.1.0
    Derivation diff
    - /nix/store/nbnqr442x2r8vhwxbafdswqsmxf7sr8d-flake-review-0.1.0.drv:{out}
    + /nix/store/3gjrgciwqqx7hvmm4hsz0qh7hjab76b2-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        ←/nix/store/4mw2l24mfii0jza5hxjjb3fad14s6a6m-source←→/nix/store/09myv4bvvj05cz9z6rg134mqdandb9l4-source→
    ''
  • packages.x86_64-linux.default

    • Output: /nix/store/7k5d5fxkjlpil9d8wjwxllz7hicmrrcn-flake-review-0.1.0
    Derivation diff
    - /nix/store/gf0c6sb1531imbzl3r4j3dgp3bg3wi0l-flake-review-0.1.0.drv:{out}
    + /nix/store/sfxqfy4yfkz7qgvwbhlvvky0p2rhra2c-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        ←/nix/store/4mw2l24mfii0jza5hxjjb3fad14s6a6m-source←→/nix/store/09myv4bvvj05cz9z6rg134mqdandb9l4-source→
    ''
  • packages.x86_64-linux.flake-review

    • Output: /nix/store/7k5d5fxkjlpil9d8wjwxllz7hicmrrcn-flake-review-0.1.0
    Derivation diff
    - /nix/store/gf0c6sb1531imbzl3r4j3dgp3bg3wi0l-flake-review-0.1.0.drv:{out}
    + /nix/store/sfxqfy4yfkz7qgvwbhlvvky0p2rhra2c-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        ←/nix/store/4mw2l24mfii0jza5hxjjb3fad14s6a6m-source←→/nix/store/09myv4bvvj05cz9z6rg134mqdandb9l4-source→
    ''

Generated by flake-review

@ojsef39 ojsef39 closed this Mar 14, 2026
@ojsef39 ojsef39 deleted the test branch March 14, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants