Skip to content

Fix quotes for "on_entity" in generated sql for PGFunction and PGTrigger #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix quotes for "on_entity" in generated sql for PGFunction and PGTrigger #148

wants to merge 1 commit into from

Conversation

janfrederik
Copy link

The generated create and drop statements didn't quote the on_entity schema/tablename. So alembic upgrade errored on statements like

DROP TRIGGER "modified" ON test.MyCamelCaseTable

This patch fixes this.

It seems correct for the other entities.

@Apteryx0 Apteryx0 mentioned this pull request Apr 11, 2025
Open
Apteryx0
Apteryx0 approved these changes Apr 11, 2025
View reviewed changes
Copy link

@Apteryx0 Apteryx0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me in my code-base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Apteryx0 Apteryx0 Apteryx0 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janfrederik @Apteryx0