Log exceptions that happen when reporting metrics #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, if an exception happens inside report_now, it is wholly ignored This means that if there is a fault in the reporter, it may silently sit there, not reporting anything, without anyone's knowledge. Add some basic logging of caught exceptions so that they show up in user's logs and so that they are able to inspect problems when they arise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, if an exception happens inside report_now, it is wholly ignored This means that if there is a fault in the reporter, it may silently sit there, not reporting anything, without anyone's knowledge.
Add some basic logging of caught exceptions so that they show up in user's logs and so that they are able to inspect problems when they arise.