Converted enums to template literals

[mfbz]

Close #2263

As suggested by @jribbink in #2263 comment, I removed enums and substituted them with their type compatible version like this:

const SomeEnum = {
  FOO: "foo"
} as const

type SomeEnum = (typeof SomeEnum)[keyof typeof SomeEnum]

Furthermore, I adjusted some files to support the new type usage instead of enums

[changeset-bot]

🦋 Changeset detected

Latest commit: 884328d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@onflow/fcl-core	Minor
@onflow/typedefs	Minor
@onflow/sdk	Minor
@onflow/fcl	Minor
@onflow/fcl-react-native	Minor
@onflow/fcl-ethereum-provider	Major
@onflow/transport-http	Minor
@onflow/util-logger	Minor
@onflow/util-rpc	Minor
@onflow/fcl-wc	Major
@onflow/fcl-rainbowkit-adapter	Major
@onflow/fcl-wagmi-adapter	Major
@onflow/kit	Major
@onflow/config	Patch
@onflow/types	Patch
@onflow/util-template	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Copilot]

Pull Request Overview

This PR converts enums into constant objects with associated type extraction, improving type compatibility across the codebase.

• Replaces enums with template literal style constant objects in various packages.
• Updates type references to align with the new constant objects.
• Adjusts error handling logic in the transaction module to accommodate the changes.

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/util-rpc/src/rpc-error.ts	Converted RpcErrorCode to a constant object with type extraction.
packages/util-rpc/src/rpc-client.ts	Replaced ReservedRpcMethods enum conversion with a constant object.
packages/util-logger/src/util-logger.ts	Converted LEVELS enum to a constant object and updated type accordingly.
packages/typedefs/src/subscriptions.ts	Converted SubscriptionTopic enum into a constant object and updated its type.
packages/typedefs/src/interaction.ts	Replaced several enums (InteractionTag, InteractionStatus, TransactionRole, InteractionResolverKind) with constant objects and updated types.
packages/typedefs/src/index.ts	Converted SignatureAlgorithm, HashAlgorithm, and TransactionExecutionStatus enums into constant objects with type extraction.
packages/typedefs/src/fvm-errors.ts	Converted FvmErrorCode enum to a constant object with type extraction.
packages/transport-http/src/subscribe/models.ts	Converted Action enum into a constant object and updated type references in message interfaces.
packages/transport-http/src/subscribe/handlers/*.ts	Updated various subscription handlers to use constant object types instead of enums.
packages/sdk/src/resolve/resolve-accounts.ts	Replaced ROLES enum with a constant object and updated type usage.
packages/fcl/src/discovery/rpc/requests.ts	Converted DiscoveryNotification and FclRequest enums into constant objects with corresponding types.
packages/fcl-wc/src/constants.ts	Converted FLOW_METHODS and REQUEST_TYPES enums to constant objects with type extraction.
packages/fcl-ethereum-provider/src/util/errors.ts	Converted ProviderErrorCode enum into a constant object with type extraction.
packages/fcl-ethereum-provider/src/constants.ts	Converted FlowNetwork, ContractType, and EventType enums into constant objects with updated types.
packages/fcl-core/src/transaction/transaction-error.ts	Adjusted error type lookup to use a runtime search over FvmErrorCode keys.
.changeset/strong-onions-behave.md	Updated changeset to reflect the conversion changes across packages.

[Copilot]

[nitpick] Consider creating a reverse mapping for FvmErrorCode to enable a constant-time lookup of the error type instead of iterating over keys at runtime, which may improve performance and clarity.

[mfbz]

Implemented!

[chasefleming]

Is this going to break any existing typedefs usage?

[mfbz]

Can you give an example? Consider that the usage is exactly the same:

Before:

enum SomeEnum {
  FOO = "foo"
}

// Usage
SomeEnum.FOO

After:

const SomeEnum = {
  FOO: "foo"
} as const
type SomeEnum = (typeof SomeEnum)[keyof typeof SomeEnum]

// Usage
SomeEnum.FOO