-
Notifications
You must be signed in to change notification settings - Fork 51
Add events for withholding node rewards #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
should we include a ReasonCode? and then have a table either on chain or just in the docs to begin with which has the mapping of |
|
That is a good idea. I will probably need you to create that page in the docs site though because you'll know those better than I do. Once that page is on the docs site, I can add a link to it in a comment in the contract. Do we think just having the reason code as a |
i don't think we will have more than 2^8 (256) reasons so UInt8 sounds good. |
8a86619 to
e0d067e
Compare
e0d067e to
298b6d7
Compare
Closes #446
Adds two events to indicate when nodes are marked to get their rewards withheld and when the withheld rewards are actually calculated