Skip to content

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Aug 29, 2025

Work Towards: #863
Work Towards: #864

Description

Note: Back-port of #867, specifically adapted to work with the soft-finality feature.

The changes include

  • Listen for any FlowFees.FeeParametersChanged events
  • Index the surgeFactor field from the above event payload
  • Update eth_gasPrice to return the configured gas-price multiplied with the latest surgeFactor
  • Update eth_maxPriorityFeePerGas to return the configured gas-price multiplied with the latest surgeFactor
  • Update eth_feeHistory to return the configured gas-price multiplied with the latest surgeFactor
  • Update eth_sendRawTransaction to reject tx submissions with gas prices below the configured gas-price multiplied with the latest surgeFactor

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Contributor

coderabbitai bot commented Aug 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mpeter/surge-factor-for-soft-finality

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants