Do not generate stablehlo.dynamic_broadcast_in_dim when shapes are same. #3328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the input and output have a dynamic shape such that the rank of input matches the rank of output and shapes are compatible (i.e. no broadcasting is needed), then the dynamic_broadcast_in_dim is effectively a no-op. Signed-off-by: nikhil-m-k <[email protected]>
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
@jenkins-droid test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the input and output have a dynamic shape such that the rank of input matches the rank of output and shapes are compatible (i.e. no broadcasting is needed), then the dynamic_broadcast_in_dim is effectively a no-op.