Fix round_robin_web_test_helpers to return 4 items instead of 5 #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function was incorrectly creating 5 test helpers (0-4) when it should only create 4 (0-3) based on the intended distribution: - 0.th.ooni.org: 10% of traffic - 1.th, 2.th, 3.th: 30% each Changes: - Adjust shift calculation: q % 4 + 1 -> q % 3 + 1 - Use range(4) instead of range(5) - Use % 4 instead of % 5 for rotation Fixes ooni#973
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #973
Problem
The
round_robin_web_test_helpersfunction was creating 5 test helpers (0-4) but the test expected only 4 items (0-3).Solution
Updated the function to create 4 test helpers with the correct distribution:
Changes
q % 4 + 1→q % 3 + 1range(5)→range(4)% 5→% 4Testing
test_round_robin_web_test_helperspasses locally