feat(i18n): add Azerbaijani (az) locale#1409
Open
Abilovv599 wants to merge 3 commits intoopen-circle:mainfrom
Open
feat(i18n): add Azerbaijani (az) locale#1409Abilovv599 wants to merge 3 commits intoopen-circle:mainfrom
Abilovv599 wants to merge 3 commits intoopen-circle:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the Open Circle Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
the
size:XL
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds Azerbaijani (az) locale to the i18n package: new az source module and type, build script inclusion, package export mappings, and an entry in .gitignore. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
packages/i18n/scripts/build-npm.ts (1)
29-29: Import style is inconsistent with the rest of the file.All other imports use single quotes and omit the
.tsextension (e.g.,import ar from '../src/ar';). Line 29 uses double quotes and includes.ts.🔧 Proposed fix
-import az from "../src/az.ts"; +import az from '../src/az';🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/i18n/scripts/build-npm.ts` at line 29, The import statement for az is inconsistent: change the line importing az (currently "import az from \"../src/az.ts\";") to use single quotes and omit the .ts extension so it matches other imports (e.g., follow the pattern used by imports like import ar from '../src/ar'). Ensure the symbol name az and the relative path remain the same aside from quote style and removing the file extension.packages/i18n/scripts/build-jsr.ts (1)
30-30: Same import style inconsistency asbuild-npm.ts.🔧 Proposed fix
-import az from "../src/az.ts"; +import az from '../src/az';🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/i18n/scripts/build-jsr.ts` at line 30, The import in build-jsr.ts uses a different style than build-npm.ts; update the import statement for the az module to match the style used in build-npm.ts (e.g., change import az from "../src/az.ts"; to the extension-less form used in build-npm.ts) so the az symbol is imported consistently across both scripts.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
packages/i18n/.gitignorepackages/i18n/jsr.jsonpackages/i18n/package.jsonpackages/i18n/scripts/build-jsr.tspackages/i18n/scripts/build-npm.tspackages/i18n/src/az.tspackages/i18n/src/types.ts
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/i18n/scripts/build-jsr.ts`:
- Line 30: The import in build-jsr.ts uses a different style than build-npm.ts;
update the import statement for the az module to match the style used in
build-npm.ts (e.g., change import az from "../src/az.ts"; to the extension-less
form used in build-npm.ts) so the az symbol is imported consistently across both
scripts.
In `@packages/i18n/scripts/build-npm.ts`:
- Line 29: The import statement for az is inconsistent: change the line
importing az (currently "import az from \"../src/az.ts\";") to use single quotes
and omit the .ts extension so it matches other imports (e.g., follow the pattern
used by imports like import ar from '../src/ar'). Ensure the symbol name az and
the relative path remain the same aside from quote style and removing the file
extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit