Skip to content

Commit d34e00f

Browse files
zhujian7claude
andcommitted
Rename SetTemplateBasedAddOn to SetTemplateMode for better clarity
- Update method name from SetTemplateBasedAddOn to SetTemplateMode - Change parameter name from templateBasedAddOn to enabled - Keep existing comments and documentation unchanged - Provides cleaner, more intuitive API naming Usage becomes: manager.SetTemplateMode(true) // Enable template mode 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: zhujian <[email protected]>
1 parent b99e2e5 commit d34e00f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

pkg/addonmanager/base_manager.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ func (a *BaseAddonManagerImpl) Trigger(clusterName, addonName string) {
7272
}
7373
}
7474

75-
// SetTemplateBasedAddOn configures whether the manager is handling template-based addons.
75+
// SetTemplateMode configures whether the manager is handling template-based addons.
7676
// - true: all ManagedClusterAddOn controllers except "addon-config-controller" will only process addons
7777
// when the referenced AddOnTemplate resources in their status.configReferences are properly set;
7878
// the "addon-config-controller" is responsible for setting these values
@@ -81,8 +81,8 @@ func (a *BaseAddonManagerImpl) Trigger(clusterName, addonName string) {
8181
// This prevents premature processing of template-based addons before their configurations
8282
// are fully ready, avoiding unnecessary errors and retries.
8383
// See https://github.com/open-cluster-management-io/ocm/issues/1181 for more context.
84-
func (a *BaseAddonManagerImpl) SetTemplateBasedAddOn(templateBasedAddOn bool) {
85-
a.templateBasedAddOn = templateBasedAddOn
84+
func (a *BaseAddonManagerImpl) SetTemplateMode(enabled bool) {
85+
a.templateBasedAddOn = enabled
8686
}
8787

8888
func (a *BaseAddonManagerImpl) StartWithInformers(ctx context.Context,

pkg/addonmanager/interface.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ type BaseAddonManager interface {
2222
// only trigger the deploy controller.
2323
Trigger(clusterName, addonName string)
2424

25-
// SetTemplateBasedAddOn configures whether the manager is handling template-based addons.
26-
SetTemplateBasedAddOn(templateBasedAddOn bool)
25+
// SetTemplateMode configures whether the manager is handling template-based addons.
26+
SetTemplateMode(enabled bool)
2727

2828
// StartWithInformers starts all registered addon agent with the given informers.
2929
StartWithInformers(ctx context.Context,

0 commit comments

Comments
 (0)