feat: Add an annotation to allow for hub appsub bypassing Git clone

[mikeshng]

feat: Add an annotation to allow for hub appsub bypassing Git clone operations to speed up appsub propagation to managed cluster

The annotation is placed on the hub appsub. An example is:

apiVersion: apps.open-cluster-management.io/v1
kind: Subscription
metadata:
  annotations:
    apps.open-cluster-management.io/skip-hub-validation: 'true'

• I have taken backward compatibility into consideration.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mikeshng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mikeshng]

/hold

Just testing the e2e right now without any real changes yet.

/assign @fxiang1

/assign @rokej

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.39%. Comparing base (e85fafa) to head (bfc7396).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   55.51%   55.39%   -0.12%     
==========================================
  Files          96       96              
  Lines       15745    15760      +15     
==========================================
- Hits         8741     8731      -10     
- Misses       6121     6144      +23     
- Partials      883      885       +2     

Flag	Coverage Δ
unit	55.39% <ø> (-0.12%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rokej]

@mikeshng Which annotation are you adding to skip cloning Git repos?

[mikeshng]

@mikeshng Which annotation are you adding to skip cloning Git repos?

I am thinking apps.open-cluster-management.io/skip-hub-git-clone: "true"

I haven't added it yet. Please let me know your preferences. @fxiang1 @rokej

[fxiang1]

@mikeshng Which annotation are you adding to skip cloning Git repos?

I am thinking apps.open-cluster-management.io/skip-hub-git-clone: "true"

I haven't added it yet. Please let me know your preferences. @fxiang1 @rokej

If we're not using the annotation for other repo types then that looks good to me.

[mikeshng]

If we're not using the annotation for other repo types then that looks good to me.

That's a great point Feng! I should just say skip-hub-validation so: apps.open-cluster-management.io/skip-hub-validation: "true"

[rokej]

@mikeshng Is the annotation added to a subscription, channel or the controller?

[mikeshng]

@mikeshng Is the annotation added to a subscription, channel or the controller?

I am hoping in the subscription because that's makes it clear which individual subscription will skip the hub validation phase.

[mikeshng]

/unhold

[fxiang1]

/lgtm

[fxiang1]

/hold

In case @rokej has any comments

[rokej]

/lgtm

[mikeshng]

/unhold