Skip to content

Conversation

guptagunjan
Copy link
Contributor

Description

orchestrator upgrade fix for application version

Changes

The solution make sure application versions get updated after orchestrator upgrade

Additional Information

Include any additional information, such as how to test your changes.

Checklist

  • [X ] Tests passed
  • Documentation updated

annotations := watcherObj.GetAnnotations()
currentTag := ""
if annotations != nil {
currentTag = annotations[ManifestTagAnnotationKey]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if annotations[ManifestTagAnnotationKey] is not present?

log.Infof("Watch %s for project %s already provisioned but manifest tag needs update. Have '%s', want '%s'",
watcherObj.DisplayName(), project.DisplayName(), currentTag, expectedTag)
action = "update"
} else if currentTag != expectedTag {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment differentiating how the update in this if statement is different from the previous one? Not sure why we need both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants