Skip to content

Conversation

guptagunjan
Copy link
Contributor

Description

Describe the purpose of this pull request.

Changes

List the changes you have made.

Additional Information

Include any additional information, such as how to test your changes.

Checklist

  • Tests passed
  • Documentation updated

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@guptagunjan guptagunjan requested a review from Copilot October 13, 2025 16:28
…in permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive component tests for the Application Orchestration Tenant Controller (AOTC) project, establishing a complete testing framework to validate system integration and plugin workflows. The tests focus on validating component interactions, plugin lifecycle management, and service integrations without requiring full external service dependencies.

  • Implements component test framework with mock services and test infrastructure
  • Adds comprehensive test coverage for plugins, manager, southbound services, and Nexus hook integration
  • Creates automated test environment setup and cleanup scripts for reproducible testing

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/utils/service.go Service health checking and project utilities for component tests
test/scripts/setup-test-env.sh Automated KIND cluster setup with mock services for testing
test/scripts/cleanup-test-env.sh Environment cleanup and context restoration
test/component/*.go Component test suites covering plugins, manager, nexus hooks, and southbound services
.github/workflows/*.yaml CI workflow and Kubernetes manifests for mock services
Makefile Component test target and automation
VERSION, Chart.yaml Version bump to 0.4.3

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@guptagunjan guptagunjan requested a review from Copilot October 13, 2025 17:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@scottmbaker scottmbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem more like unit tests to me than component-level tests. I had expected something more similar to the catalog component level tests that deployed an orchestrator using VIP and then tested the component against that orchestrator. That said, the catalog component tests seem to be fragile and time consuming, whereas these tests seem to be much more stable and very fast. What I'm concerned about is that a lot them are just testing structure and not integration. For example, I don't think the mock components are responding with APIs. For example, the comment "we test the validation and structure instead of actual project deletion". I think the goal of component level tests would be to test the actual deletion, either with mock components to interact with, or the real thing.

@guptagunjan guptagunjan changed the title AOTC component tests WIP: AOTC component tests Oct 14, 2025
@guptagunjan guptagunjan added the run-component-tests Run component tests label Oct 21, 2025
@guptagunjan guptagunjan added run-component-tests Run component tests and removed run-component-tests Run component tests labels Oct 21, 2025
@guptagunjan guptagunjan added run-component-tests Run component tests and removed run-component-tests Run component tests labels Oct 21, 2025
@guptagunjan guptagunjan added run-component-tests Run component tests and removed run-component-tests Run component tests labels Oct 21, 2025
@guptagunjan guptagunjan added run-component-tests Run component tests and removed run-component-tests Run component tests labels Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants