-
Notifications
You must be signed in to change notification settings - Fork 0
WIP: AOTC component tests #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive component tests for the Application Orchestration Tenant Controller (AOTC) project, establishing a complete testing framework to validate system integration and plugin workflows. The tests focus on validating component interactions, plugin lifecycle management, and service integrations without requiring full external service dependencies.
- Implements component test framework with mock services and test infrastructure
- Adds comprehensive test coverage for plugins, manager, southbound services, and Nexus hook integration
- Creates automated test environment setup and cleanup scripts for reproducible testing
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
test/utils/service.go | Service health checking and project utilities for component tests |
test/scripts/setup-test-env.sh | Automated KIND cluster setup with mock services for testing |
test/scripts/cleanup-test-env.sh | Environment cleanup and context restoration |
test/component/*.go | Component test suites covering plugins, manager, nexus hooks, and southbound services |
.github/workflows/*.yaml | CI workflow and Kubernetes manifests for mock services |
Makefile | Component test target and automation |
VERSION, Chart.yaml | Version bump to 0.4.3 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seem more like unit tests to me than component-level tests. I had expected something more similar to the catalog component level tests that deployed an orchestrator using VIP and then tested the component against that orchestrator. That said, the catalog component tests seem to be fragile and time consuming, whereas these tests seem to be much more stable and very fast. What I'm concerned about is that a lot them are just testing structure and not integration. For example, I don't think the mock components are responding with APIs. For example, the comment "we test the validation and structure instead of actual project deletion". I think the goal of component level tests would be to test the actual deletion, either with mock components to interact with, or the real thing.
Description
Describe the purpose of this pull request.
Changes
List the changes you have made.
Additional Information
Include any additional information, such as how to test your changes.
Checklist