Skip to content

Conversation

@hyunsun
Copy link
Contributor

@hyunsun hyunsun commented Apr 1, 2025

Disabled version checks and smoke test until initial tags are created

@jokuniew
Copy link
Contributor

jokuniew commented Apr 2, 2025

make test target is passing locally. re-triggering CI

@jdanieck jdanieck self-assigned this Apr 2, 2025
@jokuniew
Copy link
Contributor

jokuniew commented Apr 2, 2025

The controller's test refers to local files that should be created by go mod vendor.
So go mod vendor needs to be run before test suite
Update: vendoring was happening, but version used in test suite was wrong

image

@jdanieck
Copy link
Contributor

jdanieck commented Apr 2, 2025

The controller's test refers to local files that should be created by go mod vendor. So go mod vendor needs to be run before test suite

image

@jokuniew that is suprising dependency to me. We are going to remove vendoring when we are trully opensource. Did we write those tests ?

@jokuniew jokuniew changed the title Force publish latest version chore: force publish latest version Apr 2, 2025
@jokuniew
Copy link
Contributor

jokuniew commented Apr 2, 2025

@jdanieck yes, I wrote those tests.
The problem with crd references in controller's test suites are unfortunately "known issue" on kubebuilder's repo
See: issue 369 on https://github.com/kubernetes-sigs/kubebuilder repo

@jdanieck jdanieck merged commit 113d37e into main Apr 2, 2025
4 of 5 checks passed
@jdanieck jdanieck deleted the publish branch April 18, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants