Skip to content

Conversation

@eoghanlawless
Copy link
Contributor

@eoghanlawless eoghanlawless commented Apr 10, 2025

implementing /metrics endpoint to expose prometheus metrics

Signed-off-by: eoghanlawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
@eoghanlawless eoghanlawless marked this pull request as ready for review April 28, 2025 13:31
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Copy link
Contributor

@adorney99 adorney99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that familiar with promhttp syntax but lgtm if metrics are getting exported

Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
Signed-off-by: Eoghan Lawless <[email protected]>
@eoghanlawless eoghanlawless changed the title feat: /v2/metrics feat: /metrics Apr 29, 2025
@gcgirish
Copy link
Contributor

  1. Who is consuming these metrics?
  2. Who defines what metrics should be collected and how are these metrics getting reported at system wide dashboard (if there is one).
  3. How is this feature tested?
  4. Is there a larger EMF wide feature that is dealing with scraping these metrics across various subsystems?

@eoghanlawless
Copy link
Contributor Author

  1. Who is consuming these metrics?
  2. Who defines what metrics should be collected and how are these metrics getting reported at system wide dashboard (if there is one).
  3. How is this feature tested?
  4. Is there a larger EMF wide feature that is dealing with scraping these metrics across various subsystems?
  1. We're creating a Grafana dashboard to monitor these metrics to help with scale testing.
  2. We currently define the metrics and will add to them when needed, these metrics are exported to an orchestrator wide Grafana service (where we're creating a dashboard).
  3. This feature has been manually tested E2E on a Coder environment by querying our exported metrics from the Grafana service (and manually scraping our /metrics endpoint).
  4. I'm not sure what you mean here, but each service that wants to export metrics to Grafana needs to create a Prometheus ServiceMonitor resource that targets their metrics endpoint through their service.

Copy link
Contributor

@togashidm togashidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments

@eoghanlawless eoghanlawless merged commit 360b8d0 into main May 1, 2025
19 of 20 checks passed
@eoghanlawless eoghanlawless deleted the metrics branch May 1, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants