Cluster force delete fixes #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdanieck
requested review from
eoghanlawless,
gcgirish,
hyunsun and
jokuniew
as code owners
eoghanlawless
approved these changes
Jun 6, 2025
togashidm
reviewed
Jun 6, 2025
| return api.DeleteV2ClustersNameNodesNodeId500JSONResponse{N500InternalServerErrorJSONResponse: api.N500InternalServerErrorJSONResponse{Message: &errMsg}}, nil | ||
| } | ||
| // check for single node | ||
| if len(*cluster.Nodes) == 1 { |
There was a problem hiding this comment.
if I understood, there is always a nodeID when there is a cluster in it?
There was a problem hiding this comment.
this was the original assumption that there is always node assosciated with the cluster; but there are cases that provisioning failed and there is no node (cluster is in broken state) and we couldnt delete cluster beacuse of this check; anyways, this is only temporary as we will have new delete flow for 3.1; see #91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes in cluster force delete. Previous code (wrongly) assumed that nodes are always allocated and healthy.
How Has This Been Tested?
Unit tested & manually on the real Orchestrator.
Checklist: