Skip to content

Conversation

@AdityaSinghDevs
Copy link

Summary

Summary of changes made to NDR transform plugin:

Added functionality to:

  1. Support core set frame list dumping via new CLI options and methods:

    • get_core_set_item_ids()
    • save_core_set_item_ids()
  2. Enable computed state handling for multiple input sources:

    • append_state()
    • compute_state()

Added corresponding CLI arguments:

  • --save_media : Saves Core set frame list in directory
  • --output_dir : Specify directory to save the media files.

These changes allow efficient processing of large video datasets by:

  • Enabling frame list exports for further analysis
  • Supporting state management across multiple sources without RAM constraints

Resolves #140

How to test

Process dataset with multiple video sources using:
python ndr.py --save-core-set core_frames.list --save-deduplicated dedup.list output_dir

Verify outputs:

  1. Check core_frames.list contains selected frame IDs
  2. Verify dedup.list contains deduplicated frame IDs
  3. Confirm output_dir structure matches expected format

Test with large datasets:

  1. Use multiple video sequences >100k frames
  2. Verify memory usage remains stable
  3. Confirm state management works across sources

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file

@AdityaSinghDevs AdityaSinghDevs requested review from a team as code owners January 17, 2025 23:16
@AdityaSinghDevs AdityaSinghDevs requested review from wonjuleee and removed request for a team January 17, 2025 23:16
@atwinand atwinand requested a review from djdameln January 29, 2025 08:08
@AdityaSinghDevs
Copy link
Author

Hi @djdameln , @wonjuleee , @zhiltsov-max
Just checking in on this PR. Let me know if you need any changes or feedback.
Would appreciate a review when you get a chance. Thanks!

@AdityaSinghDevs
Copy link
Author

Hey,
It's been quite some time since I made this PR, I would appreciate a review from the maintainers side, about any changes or feedback needed @djdameln @wonjuleee @zhiltsov-max , Can you please look into this.

@sovrasov
Copy link
Member

sovrasov commented Apr 9, 2025

Hey, It's been quite some time since I made this PR, I would appreciate a review from the maintainers side, about any changes or feedback needed @djdameln @wonjuleee @zhiltsov-max , Can you please look into this.

Hi @AdityaSinghDevs thanks for your contribution! We appreciate you patience, and started looking if we can accept your PR. Expect updates in the nearest future

self.algorithm_specific = kwargs
self.kept_item_id = None
self._initialized = False
self.save_media= save_media
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before = is missing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
I'll resolve it, can you tell me if there are any other changes needed? I can compile the changes and push them all at once.
Thankyou

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, that's it. Perhaps @djdameln has something to add
Also, it'd be extremely convenient for us if you provide as small video dataset to check if the plugin is not broken after the refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to keep the most significant video frames in dataset

2 participants