Skip to content

Conversation

@ktaube26
Copy link
Contributor

@ktaube26 ktaube26 commented Dec 4, 2025

Description

This PR fixes a device name comparison issue in the ViPPET video encoder to support multiple GPU identifier formats. The change replaces an exact string match with a prefix match, allowing device names like "GPU.0", "GPU.1", etc., to be correctly identified as GPU devices.

Key Changes:

  • Modified GPU device detection logic to use startswith() instead of exact equality check

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes.
  • I have not introduced any 3rd party components incompatible with APACHE-2.0.
  • I have not included any company confidential information, trade secret, password or security token.
  • I have performed a self-review of my code.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a device name comparison issue in the ViPPET video encoder to support multiple GPU identifier formats. The change replaces an exact string match with a prefix match, allowing device names like "GPU0", "GPU1", etc., to be correctly identified as GPU devices.

Key Changes:

  • Modified GPU device detection logic to use startswith() instead of exact equality check

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ktaube26 ktaube26 merged commit 4b5e24c into main Dec 5, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants