[ViPPET] Use python bindings instead invoking gstreamer using a subprocess #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktaube26
commented
Sep 12, 2025
| try: | ||
| # Set the environment variable to enable all drivers | ||
| env = os.environ.copy() | ||
| env["GST_VA_ALL_DRIVERS"] = "1" |
Contributor
Author
There was a problem hiding this comment.
Removed the GST_VA_ALL_DRIVERS env variable because it is set by default in the DLStreamer base image
ktaube26
commented
Sep 12, 2025
Comment on lines
+422
to
+425
| # ----------------------------------------------------------------------- | ||
| # Potential implementation if no better way to read FPS metrics is found: | ||
| # Implement reading FPS metrics from the fps-metrics.txt file | ||
| # ----------------------------------------------------------------------- |
Contributor
Author
There was a problem hiding this comment.
#TODO: Implement reading FPS metrics from the fps-metrics.txt file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. List any dependencies that are required for this change.
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: