-
Couldn't load subscription status.
- Fork 1.5k
Fixes #23880: Add new policy conditions isReviewer() and !isReviewer #23986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fixes #23880: Add new policy conditions isReviewer() and !isReviewer #23986
Conversation
…into feature/add-reviewer-condition
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
|



Describe your changes:
Fixes #23880
I worked on adding a new policy condition
isReviewer()(and its negation!isReviewer) because there was previously no way to check if a user is listed as a reviewer of an entity during policy evaluation.This condition helps improve access control flexibility which is similar to
isOwner()but applied to thereviewersfield.I tested my changes by:
SubjectContextTest.javato verify thatisReviewer()and!isReviewer()return correct results.RuleEvaluatorTest.javato ensure reviewer-based conditions are properly evaluated during policy execution.ElasticSearchRBACConditionEvaluatorTest.javato verify that reviewer-based conditions are correctly translated into Elasticsearch queries.Type of change:
Checklist:
Fixes <issue-number>: <short explanation>New feature
or decision-making process is reflected in the issue.