Skip to content

Conversation

@Rohit0301
Copy link
Contributor

Describe your changes:

Previously, the feedType for Incident Manager notifications was hardcoded from Task to Conversation.
This caused incorrect redirection links to be generated for mention notifications.
PR- #23874

Fix:
Introduced a separate boolean variable to determine which function (getTaskDetailPath or prepareFeedLink) should be used to build the redirection link.

Screen.Recording.2025-10-27.at.6.18.02.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant