Skip to content

gitbisect: add shallow-since and commit date option #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gitbisect: add shallow-since and commit date option #899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions testcases/OpTestKernelTest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ def setUp(self):
self.home = self.conf.args.git_home
self.config_path = self.conf.args.git_repoconfigpath
self.good_commit = self.conf.args.good_commit
self.commit_date = self.conf.args.commit_date
self.bad_commit = self.conf.args.bad_commit
self.append_kernel_cmdline = self.conf.args.append_kernel_cmdline
self.linux_path = os.path.join(self.home, "linux")
Expand Down Expand Up @@ -217,9 +218,10 @@ def runTest(self):
self.con.run_command("cd {}".format(self.home))
if not self.branch:
self.branch='master'
self.con.run_command("git clone -b {} {} linux".format( self.branch, self.repo),timeout=3000)
self.con.run_command("git clone --shallow-since={} -b {} {} linux".format(self.commit_date, self.branch, self.repo),timeout=3000)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see git clone command being used in other places in the code, dont we need to use --shallow there?

self.con.run_command("cd linux")
commit = self.con.run_command(" git log -1 --format=%H | sed -r 's/\x1B\[[0-9:]*[JKsu]//g'")
commit_date = self.con.run_command("git show -s --format=%ci {} | awk -F ' ' '{print $1}'".format(commit))
self.con.run_command("cd ..")
error = self.build_kernel()
exit_code = error[0]
Expand All @@ -245,7 +247,7 @@ def runTest(self):
emaili=""
commiti=commit[-1]
with open('output.json','w') as f:
json.dump({"exit_code":exit_code,"email":emaili,"commit": commiti,"error":entry,"err_msg":err_msg,"flag":self.bisect_flag},f)
json.dump({"exit_code":exit_code,"email":emaili,"commit": commiti, "commitDate": commit_date, "error":entry,"err_msg":err_msg,"flag":self.bisect_flag},f)
if exit_code != 0:
self.util.format_email(self.linux_path, self.repo)

Expand Down