Introduce service.Settings.TelemetryFactory #13838
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
service-settings-telemetryfactory
branch
3 times, most recently
from
902c8dc to
875114a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13838 +/- ##
==========================================
- Coverage 91.66% 91.66% -0.01%
==========================================
Files 652 653 +1
Lines 42520 42551 +31
==========================================
+ Hits 38978 39006 +28
- Misses 2736 2739 +3
Partials 806 806 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
axw
force-pushed
the
service-settings-telemetryfactory
branch
from
875114a to
85d7247
Compare
The `service.Settings` type now has a `TelemetryFactory` field for injecting the `telemetry.Factory` to be used for creating a logger and logger provider, meter provider, and tracer provider. The `otelcol` package is hard-coded to inject an otelconftelemetry factory for now. In a followup we will make it possible to inject the telemetry through `otelcol.Factories`.
axw
force-pushed
the
service-settings-telemetryfactory
branch
from
85d7247 to
872b902
Compare
axw
commented
Sep 15, 2025
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking |
There was a problem hiding this comment.
Note to reviewer: I've put this down as a breaking API change because the new setting is required.
bogdandrutu
previously requested changes
Sep 18, 2025
There was a problem hiding this comment.
Before moving forward, I really want to first fix #4970 (comment)
mx-psi
reviewed
Sep 26, 2025
There was a problem hiding this comment.
Typically we split the test package(s) into a separate module. Does it make sense to do that here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
service.Settingstype now has aTelemetryFactoryfield for injecting thetelemetry.Factoryto be used for creating a logger and logger provider, meter provider, and tracer provider. Theotelcolpackage is hard-coded to inject anotelconftelemetryfactory for now. In a followup we will make it possible to inject the telemetry throughotelcol.Factories.Link to tracking issue
Part of #4970
Testing
Manually verified that service telemetry configuration still works with a collector binary.
Documentation
N/A