feat: migrate to tools directive (v2) #13906
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See [1] for more details on the tools directive. [1]: https://go.dev/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module
Open
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13906 +/- ##
==========================================
+ Coverage 91.65% 91.68% +0.02%
==========================================
Files 652 652
Lines 42506 42506
==========================================
+ Hits 38960 38972 +12
+ Misses 2737 2728 -9
+ Partials 809 806 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation of PR #13844 , which had to be reverted in #13899, because of an issue with the
apidifftool as described in #13897 .On top of the changes initially proposed in #13844, this PR also adds the gomodTidy option to renovate postUpdateOptions, so that module dependencies are properly updated before new changes are proposed by
renovate.The changes from this PR have been applied to my fork, so that I can confirm that all workflows are passing as expected and a couple of dummy PRs can be seen below.
renovatewhich takes care of updating a Go tool)cc: @mx-psi , @dmathieu , @codeboten
P.S.: Sorry for the troubles caused by the initial PR!
Link to tracking issue
Fixes #13897
Testing
Local testing as well as testing with PRs against my fork (see links in the description for sample PRs and workflow runs)
Documentation
N/A