Skip to content

Conversation

@CodeBlanch
Copy link
Member

Relates to #2021

Changes

  • Harden the validation introduced on [OneCollector] Introduce EventFullNameMappings on options #2021 to prevent mappings with a trailing wildcard.

    • Before
      • Invalid: { ["Prefix"] = "*.Name" }, { ["Prefix"] = "*.*" }
      • Valid: { ["Prefix"] = "*" }, { ["Prefix"] = "Namespace.*" } (unintentional)
    • After
      • Invalid: { ["Prefix"] = "*.Name" }, { ["Prefix"] = "*.*" }, { ["Prefix"] = "Namespace.*" }
      • Valid: { ["Prefix"] = "*" }
  • Add additional tests to cover more possible user inputs and capture supported use cases.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated

@CodeBlanch CodeBlanch requested a review from a team September 7, 2024 04:54
@github-actions github-actions bot requested a review from reyang September 7, 2024 04:54
@github-actions github-actions bot added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Sep 7, 2024
@codecov
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.32%. Comparing base (71655ce) to head (3e9ef31).
Report is 411 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2043       +/-   ##
===========================================
+ Coverage   73.91%   94.32%   +20.40%     
===========================================
  Files         267       28      -239     
  Lines        9615     1180     -8435     
===========================================
- Hits         7107     1113     -5994     
+ Misses       2508       67     -2441     
Flag Coverage Δ
unittests-Exporter.OneCollector 94.32% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ry.Exporter.OneCollector/Internal/EventFullName.cs 100.00% <100.00%> (ø)

... and 268 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 43a0aeb into open-telemetry:main Sep 9, 2024
@CodeBlanch CodeBlanch deleted the onecollector-mapping-validation branch September 9, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants