Skip to content

Conversation

@joaopgrassi
Copy link
Member

Follow up from #2040 (comment), where . were removed. Now Weaver has a feature that enforces them back.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Use the feature to ensure XML docs end with a dot at the end.
@joaopgrassi joaopgrassi requested a review from a team as a code owner September 23, 2024 14:51
@github-actions github-actions bot added the comp:semanticconventions Things related to OpenTelemetry.SemanticConventions label Sep 23, 2024
@CodeBlanch CodeBlanch changed the title Update Semantic Conventions generator version [semantic conventions] Update generator version Sep 23, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(Just scrolled through the diff didn't go deep)

@CodeBlanch CodeBlanch merged commit f66086b into open-telemetry:main Sep 23, 2024
@joaopgrassi joaopgrassi deleted the update-semconv-generator branch September 24, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:semanticconventions Things related to OpenTelemetry.SemanticConventions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants